Show 'Verify this device' toast even if there are no encrypted rooms yet#32891
Conversation
andybalaam
changed the title
andybalaam
force-pushed
the
andybalaam/always-nag-to-verify-even-if-no-e2e-rooms
branch
from
ff49ee0 to
9890505
Compare
andybalaam
force-pushed
the
andybalaam/always-nag-to-verify-even-if-no-e2e-rooms
branch
from
a463e30 to
4597d73
Compare
andybalaam
force-pushed
the
andybalaam/always-nag-to-verify-even-if-no-e2e-rooms
branch
from
3861127 to
6fe9ff7
Compare
andybalaam
force-pushed
the
andybalaam/always-nag-to-verify-even-if-no-e2e-rooms
branch
from
6fe9ff7 to
8e4be76
Compare
andybalaam
force-pushed
the
andybalaam/always-nag-to-verify-even-if-no-e2e-rooms
branch
from
ff77e2a to
d87e682
Compare
andybalaam
force-pushed
the
andybalaam/always-nag-to-verify-even-if-no-e2e-rooms
branch
from
d87e682 to
7adfd7d
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
…yet (#32891) * Show 'Verify this device' toast even if there are no encrypted rooms yet * Add missing word Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> * Close Verify toast at the start of several more tests * Reinstate comment about not showing toasts while secret storage is being accessed * Close verify toast in room-list-sections test * Share code to silence SonarQube * Close verify toast in lowbandwidth.spec.ts * Share code in Bob creation * More attempts to silence SonarQube --------- Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
|
@andybalaam I suggest opening the HTML report to inspect the failure. It is not a flake. The element-modules tests are failing due to the toast being in their way. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Thanks, today I learned that clicking "View Deployment" next to "github-actions bot deployed to EndToEndTests" opens a Playwright report with useful info. |
|
That would be the report for the |
Where do I find that? I can see the failure messages at https://github.com/element-hq/element-web/actions/runs/24236141622 but not an HTML report. |
Ah, on that same link, under Artifacts, the artifact called "html-report"? |
|
Yes that's right |
|
Attempting to fix downstream tests with element-hq/element-modules#252 |
andybalaam
force-pushed
the
andybalaam/always-nag-to-verify-even-if-no-e2e-rooms
branch
from
8c5cd7a to
b7e63a4
Compare
|
Working on element-hq/element-modules#258 to fix the latest merge queue rejection. |
|
Instead, #33158 should fix the failures we saw in the merge queue. |
3 participants
Part of https://github.com/element-hq/crypto-internal/issues/305
Depends on #32931
Checklist
public/exportedsymbols have accurate TSDoc documentation.